Remove unnecessary xref sorting on every query#25746
Closed
Conversation
trufae
force-pushed
the
optimize/remove-xref-sorting
branch
from
a03c64c to
ff08e8b
Compare
radare
force-pushed
the
optimize/remove-xref-sorting
branch
from
ff08e8b to
2d36f57
Compare
trufae
force-pushed
the
optimize/remove-xref-sorting
branch
from
2d36f57 to
20f2445
Compare
Collaborator
Author
|
well its not reliable. its not jsut unsorted, each run returns different order. so sorting is mandatory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RVecAnalRef_sortcalls fromr_anal_refs_get,r_anal_xrefs_get, andr_anal_xrefs_get_from// XXX not needed?and sorting on every query is wastefulTest plan
https://claude.ai/code/session_015tU8A23whE5bgreK4UoDNM